[Performance] Remove redundant JSON cycle in analytics#7654
[Performance] Remove redundant JSON cycle in analytics#7654gonzaloriestra wants to merge 1 commit into
Conversation
The `buildPayload` function was performing an expensive `JSON.parse(JSON.stringify(payload))` cycle to strip `undefined` fields. This is redundant because the subsequent `sanitizePayload` call already performs a full stringification and parsing pass, and `JSON.stringify` naturally omits `undefined` properties. Removing this saves an unnecessary serialization/deserialization pass on a potentially large payload object.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
WHY are these changes introduced?
The
buildPayloadfunction inpackages/cli-kit/src/public/node/analytics.tswas performing an expensiveJSON.parse(JSON.stringify(payload))cycle to stripundefinedfields. This is redundant because the subsequentsanitizePayloadcall already performs a full stringification and parsing pass, andJSON.stringifynaturally omitsundefinedproperties.WHAT is this pull request doing?
JSON.parse(JSON.stringify(payload))inbuildPayload.payloaddeclaration fromlettoconstas it is no longer reassigned.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 6213550805808898868 started by @gonzaloriestra